How long is this going to take to see a change?!

I am doing both naps and nights. He still fights his crib at night. He knows how to fall back to sleep but will cry and then go back. It’s sometimes longer than what I thought this would take.....

We have a strict bedtime routine. He is down at 7pm. The first nap he goes down without a problem. The other 2 naps he wants to be held /nurse and will cry. I still nurse him twice at night because I want to. I also nurse right before he goes down/burp and that gets him “drowsy but awake”... the moment we walk to the crib he’s up!!!!

I don’t know when the sleep teaching will be over....????

How much longer of this!