My boss has one in Aruba and she loves it.
I don't know if I've been enough places to choose. I really want to visit a lot of Caribbean islands, I haven't been down there at all.
I've been to New Zealand and LOVED IT but it would be too expensive to fly there for a timeshare over and over again.
ETA: we would likely get one in NY, just because we already go there a lot for family. It'd be fun to have a place near Montauk or Fire Island.
Where would you buy a time share?